[LayoutNG] Auto block-size shouldn't prevent child margin propagation. #18993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 11, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1796372
branch
3 times, most recently
from
9770223
to
45f641e
Compare
The block-end margin strut of a child can collapse with the block-end margin strut of the parent if the computed block-size of the child is auto. This includes unresolvable percentages (e.g. if the child has a percentage block-size, but its containing block has auto block-size). Update BlockLengthUnresolvable() to consider 'auto' as unresolvable. Also include 'min-content', 'max-content', 'fit-content' and 'none' (for max-block-size), since that seems correct, and also allows for simplifying code at call-sites. Bug: 1001663 Change-Id: I28decd41ca8f8340581fc68e0a4fe709d7389af8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796372 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: David Grogan <dgrogan@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#696253}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1796372
branch
from
45f641e
to
e295c76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The block-end margin strut of a child can collapse with the block-end
margin strut of the parent if the computed block-size of the child is
auto. This includes unresolvable percentages (e.g. if the child has a
percentage block-size, but its containing block has auto block-size).
Update BlockLengthUnresolvable() to consider 'auto' as unresolvable.
Also include 'min-content', 'max-content', 'fit-content' and 'none'
(for max-block-size), since that seems correct, and also allows for
simplifying code at call-sites.
Bug: 1001663
Change-Id: I28decd41ca8f8340581fc68e0a4fe709d7389af8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796372
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696253}