Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors for MathML tests with in-flow children. #18994

Merged
merged 1 commit into from Sep 11, 2019

Conversation

fred-wang
Copy link
Contributor

  • maction/semantics have special rules for their first child, so don't add out-of-flow at that position.
  • fix wrong id
  • fix IsInFlow helper function.

- maction/semantics have special rules for their first child, so don't add out-of-flow at that position.
- fix wrong id
- fix IsInFlow helper function.
@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request besides its author. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

Copy link
Contributor

@rwlbuis rwlbuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fred-wang fred-wang merged commit e6701a4 into master Sep 11, 2019
@fred-wang fred-wang deleted the mathml-inflow-errors branch September 11, 2019 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants