Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

morph: 1.3.0 -> 1.3.1 #68421

Merged
merged 1 commit into from Sep 10, 2019
Merged

morph: 1.3.0 -> 1.3.1 #68421

merged 1 commit into from Sep 10, 2019

Conversation

johanot
Copy link
Contributor

@johanot johanot commented Sep 10, 2019

Motivation for this change

A couple of bugfixes for morph.
Please cherry-pick to release-19.09 as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @mmahut @adamtulinius

@mmahut
Copy link
Member

mmahut commented Sep 10, 2019

@GrahamcOfBorg build morph

@mmahut
Copy link
Member

mmahut commented Sep 10, 2019

Mr. Borg is sleeping, but it builds locally.

@mmahut mmahut merged commit db03dfc into NixOS:master Sep 10, 2019
@mmahut mmahut mentioned this pull request Sep 10, 2019
Merged
10 tasks
@johanot johanot deleted the morph-1.3.1 branch September 11, 2019 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johanot @mmahut