Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editorconfig-checker: init at 2.0.2 #68476

Merged
merged 1 commit into from Nov 9, 2019
Merged

editorconfig-checker: init at 2.0.2 #68476

merged 1 commit into from Nov 9, 2019

Conversation

uri-canva
Copy link
Contributor

@uri-canva uri-canva commented Sep 11, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @dochang @FRidh @costrouc

@ofborg ofborg bot requested a review from kalbasit September 11, 2019 05:46
jonringer
jonringer approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM (1 minor suggestion)
binary seems to worok
leaf package

pkgs/development/tools/misc/editorconfig-checker/default.nix Outdated Show resolved Hide resolved
@lheckemann lheckemann added this to the 20.03 milestone Sep 12, 2019
@uri-canva
Copy link
Contributor Author

ping @jonringer

@uri-canva
Copy link
Contributor Author

ping @dochang @FRidh @costrouc @kalbasit

@jonringer
Copy link
Contributor

I'm in the same boat, i got 25 open PRs :(

@bjornfor bjornfor merged commit e3fe458 into NixOS:master Nov 9, 2019
@uri-canva uri-canva deleted the editorconfig-checker branch November 9, 2019 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@uri-canva @jonringer @bjornfor @lheckemann