Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lazydocker: 0.7 -> 0.7.4 #68460

Merged
merged 1 commit into from Sep 11, 2019
Merged

lazydocker: 0.7 -> 0.7.4 #68460

merged 1 commit into from Sep 11, 2019

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

Upstream update
Blocks #68135

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @das-g

@rvolosatovs
Copy link
Member Author

@GrahamcOfBorg build lazydocker

@rvolosatovs rvolosatovs mentioned this pull request Sep 10, 2019
Merged
10 tasks
@ofborg ofborg bot requested review from das-g and kalbasit September 10, 2019 22:35
das-g
das-g suggested changes Sep 10, 2019
View reviewed changes
Copy link
Member

@das-g das-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building with nix run -f . lazydocker fails for me with

hash mismatch in fixed-output derivation '/nix/store/2059g3x5gz3df0kmk125h80wpzbzw3fg-lazydocker-0.7.4-go-modules':
  wanted: sha256:16idjsh0mlh2xra434ywvgy1l9wzhgmbc5kx32b8jzx7w7z9i78z
  got:    sha256:1hzrin8dfsfnxpc37szc1449s235w0dr24albswz06fjnl4bbs5y
cannot build derivation '/nix/store/sq25nd0x9hyq9ry18r77lhxy5k08p3jb-lazydocker-0.7.4.drv': 1 dependencies couldn't be built
[2 built (1 failed), 106 copied (805.2 MiB), 188.0 MiB DL]
error: build of '/nix/store/sq25nd0x9hyq9ry18r77lhxy5k08p3jb-lazydocker-0.7.4.drv' failed

das-g
das-g suggested changes Sep 10, 2019
View reviewed changes
Copy link
Member

@das-g das-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(other than the hash mismatch, the change looks good to me)

pkgs/tools/misc/lazydocker/default.nix Outdated Show resolved Hide resolved
@Mic92 Mic92 merged commit 9aaebb8 into NixOS:master Sep 11, 2019
@rvolosatovs rvolosatovs deleted the update/lazydocker branch September 11, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

@das-g das-g Awaiting requested review from das-g

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rvolosatovs @das-g @Mic92