Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 70a0add412e9
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 9cbc8f38a6a7
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Sep 10, 2019

  1. qtwebkit: fixing build / reducing build log size

    GCC 8 introduced a new type of warning `-Wclass-memaccess` which
    is included in `-Wall`. This warnings spits out *a million* of warnings
    like the following:
    
    ```
    [...]
    /build/source/Source/WTF/wtf/Vector.h:128:15: warning: 'void* memcpy(void*, const void*, size_t)' writing to an object of type 'class WTF::RefPtr<WebCore::TransformOperation>' with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
             memcpy(dst, src, reinterpret_cast<const char*>(srcEnd) - reinterpret_cast<const char*>(src));
    [...]
    ``
    
    Logs demonstrating the issue:
    https://hydra.nixos.org/build/100205478/nixlog/1
    
    While I don't think disabling warnings is the best way to deal with this,
    there is alrady precedent for this package and I don't feel confident enough
    to either patch or bump this package.
    
    Please view this as a low-friction sub-optimal suggestion in case nobody else
    has a better fix.
    d-goldin committed Sep 10, 2019
    Copy the full SHA
    6f1ad06 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #68434 from d-goldin/release-19.09/qtwebtoolkit-di…

    …sable-memaccess-warnings
    
    qtwebkit: fixing build / reducing build log size
    worldofpeace committed Sep 10, 2019
    Copy the full SHA
    9cbc8f3 View commit details
    Browse the repository at this point in the history