Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build UWP with native UWP rustc target #24198

Merged
merged 5 commits into from Oct 12, 2019
Merged

Build UWP with native UWP rustc target #24198

merged 5 commits into from Oct 12, 2019

Conversation

jdm
Copy link
Member

@jdm jdm commented Sep 11, 2019 •
edited by SimonSapin

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @wafflespeanut: python/servo/command_base.py, python/servo/packages.py, python/servo/build_commands.py

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Sep 11, 2019
@jdm jdm removed the S-awaiting-review There is new code that needs to be reviewed. label Sep 11, 2019
@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Sep 11, 2019
@jdm
Copy link
Member Author

jdm commented Sep 11, 2019

@bors-servo try=windows

@bors-servo
Copy link
Contributor

⌛ Trying commit 2a5107e with merge e1bf5dd...

bors-servo pushed a commit that referenced this pull request Sep 11, 2019
Auto merge of #24198 - jdm:xargo-uwp3, r=<try>
e1bf5dd 
[WIP] Build UWP with native UWP rustc target

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24198)
<!-- Reviewable:end -->
@jdm jdm removed the S-awaiting-review There is new code that needs to be reviewed. label Sep 11, 2019
@jdm
Copy link
Member Author

jdm commented Sep 11, 2019 

warning: Patch `rustc-std-workspace-alloc v1.0.0 (C:\Users\task_1568230939\.rustup\toolchains\nightly-2019-08-26-x86_64-pc-windows-msvc\lib\rustlib\src\rust\src\tools\rustc-std-workspace-alloc)` was not used in the crate graph.
Patch `rustc-std-workspace-core v1.0.0 (C:\Users\task_1568230939\.rustup\toolchains\nightly-2019-08-26-x86_64-pc-windows-msvc\lib\rustlib\src\rust\src\tools\rustc-std-workspace-core)` was not used in the crate graph.
Check that the patched package version and available features are compatible
with the dependency requirements. If the patch has a different version from
what is locked in the Cargo.lock file, run `cargo update` to use the new
version. This may also occur with an optional dependency that is not enabled.
   Compiling core v0.0.0 (C:\Users\task_1568230939\.rustup\toolchains\nightly-2019-08-26-x86_64-pc-windows-msvc\lib\rustlib\src\rust\src\libcore)
    Finished release [optimized] target(s) in 14.49s
warning: dependency (compiler_builtins) specified without providing a local path, Git repository, or version to use. This will be considered an error in future versions
    Updating crates.io index
warning: Patch `rustc-std-workspace-alloc v1.0.0 (C:\Users\task_1568230939\.rustup\toolchains\nightly-2019-08-26-x86_64-pc-windows-msvc\lib\rustlib\src\rust\src\tools\rustc-std-workspace-alloc)` was not used in the crate graph.
Patch `rustc-std-workspace-core v1.0.0 (C:\Users\task_1568230939\.rustup\toolchains\nightly-2019-08-26-x86_64-pc-windows-msvc\lib\rustlib\src\rust\src\tools\rustc-std-workspace-core)` was not used in the crate graph.
Check that the patched package version and available features are compatible
with the dependency requirements. If the patch has a different version from
what is locked in the Cargo.lock file, run `cargo update` to use the new
version. This may also occur with an optional dependency that is not enabled.
 Downloading crates ...
  Downloaded compiler_builtins v0.1.19
   Compiling compiler_builtins v0.1.19
    Finished release [optimized] target(s) in 29.28s

error[E0463]: can't find crate for `std`
  |
  = note: the `aarch64-uwp-windows-msvc` target may not be installed

error: aborting due to previous error

@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Sep 11, 2019
@jdm
Copy link
Member Author

jdm commented Sep 12, 2019

@bors-servo try=windows

@bors-servo
Copy link
Contributor

⌛ Trying commit cddb4ff with merge 8083512...

bors-servo pushed a commit that referenced this pull request Sep 12, 2019
Auto merge of #24198 - jdm:xargo-uwp3, r=<try>
8083512 
[WIP] Build UWP with native UWP rustc target

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24198)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Sep 12, 2019
@jdm
Copy link
Member Author

jdm commented Sep 12, 2019

@bors-servo try=windows

@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Sep 12, 2019
@bors-servo
Copy link
Contributor

⌛ Trying commit 10044bc with merge 7b064c3...

bors-servo pushed a commit that referenced this pull request Sep 12, 2019
Auto merge of #24198 - jdm:xargo-uwp3, r=<try>
7b064c3 
[WIP] Build UWP with native UWP rustc target

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24198)
<!-- Reviewable:end -->
@jdm
Copy link
Member Author

jdm commented Sep 12, 2019

@bors-servo try=windows

@bors-servo
Copy link
Contributor

⌛ Trying commit a2ba74b with merge 094a643...

bors-servo pushed a commit that referenced this pull request Sep 12, 2019
Auto merge of #24198 - jdm:xargo-uwp3, r=<try>
094a643 
[WIP] Build UWP with native UWP rustc target

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24198)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Sep 12, 2019
@jdm
Copy link
Member Author

jdm commented Oct 12, 2019

@bors-servo try=windows

@bors-servo
Copy link
Contributor

⌛ Trying commit 9812305 with merge 684c74f...

bors-servo pushed a commit that referenced this pull request Oct 12, 2019
Auto merge of #24198 - jdm:xargo-uwp3, r=<try>
684c74f 
Build UWP with native UWP rustc target

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24198)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Oct 12, 2019
@jdm
Copy link
Member Author

jdm commented Oct 12, 2019

@bors-servo r=SimonSapin

@bors-servo
Copy link
Contributor

📌 Commit 9812305 has been approved by SimonSapin

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. S-tests-failed The changes caused existing tests to fail. labels Oct 12, 2019
@bors-servo
Copy link
Contributor

⌛ Testing commit 9812305 with merge e098797...

bors-servo pushed a commit that referenced this pull request Oct 12, 2019
Auto merge of #24198 - jdm:xargo-uwp3, r=SimonSapin
e098797 
Build UWP with native UWP rustc target

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24198)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - status-taskcluster

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 12, 2019
@jdm
Copy link
Member Author

jdm commented Oct 12, 2019

@bors-servo retry

@bors-servo
Copy link
Contributor

💣 Failed to start rebuilding: Unknown error

bors-servo pushed a commit that referenced this pull request Oct 12, 2019
Auto merge of #24198 - jdm:xargo-uwp3, r=SimonSapin
eee2c89 
Build UWP with native UWP rustc target

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24198)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

⌛ Testing commit 9812305 with merge eee2c89...

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Oct 12, 2019
@bors-servo
Copy link
Contributor

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: SimonSapin
Pushing eee2c89 to master...

@bors-servo bors-servo merged commit 9812305 into servo:master Oct 12, 2019
UWP port automation moved this from In progress to Done Oct 12, 2019
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 12, 2019
@bors-servo bors-servo mentioned this pull request Oct 12, 2019
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonSapin SimonSapin SimonSapin left review comments

Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
No open projects
UWP port
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jdm @highfive @bors-servo @servo-wpt-sync @SimonSapin @CYBAI