Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deluge: add missing setuptools dependency #68484

Merged
merged 1 commit into from Sep 11, 2019
Merged

deluge: add missing setuptools dependency #68484

merged 1 commit into from Sep 11, 2019

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Sep 11, 2019

Motivation for this change

Latest staging merge broke nixos/tests/deluge.nix showing an ImportError
for "pkg_resources": https://nix-cache.s3.amazonaws.com/log/h8qzkcjldal5j1925g0r04ncl5afjjnp-vm-test-run-deluge.drv

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@delroth
deluge: add missing setuptools dependency
5095638 
Latest staging merge broke nixos/tests/deluge.nix showing an ImportError
for "pkg_resources": https://nix-cache.s3.amazonaws.com/log/h8qzkcjldal5j1925g0r04ncl5afjjnp-vm-test-run-deluge.drv
@delroth
Copy link
Contributor Author

delroth commented Sep 11, 2019

@GrahamcOfBorg test deluge

@ofborg ofborg bot requested review from domenkozar and ebzzry September 11, 2019 07:24
worldofpeace
worldofpeace approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executes locally without runtime error.
Run the test locally and it succeeded.

@worldofpeace worldofpeace merged commit d400d6f into NixOS:master Sep 11, 2019
@worldofpeace
Copy link
Contributor

backported in 6f8818e

@maxkrieger maxkrieger mentioned this pull request Sep 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@domenkozar domenkozar Awaiting requested review from domenkozar

@ebzzry ebzzry Awaiting requested review from ebzzry

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@delroth @worldofpeace