New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated player for setting audio and video tracks #305
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sreeise !
Unfortunately, there is currently no way to set and play multiple audio streams with GstPlayer, so we are limited to a single audio track for now.
@bors-servo r+ |
📌 Commit 8c8103b has been approved by |
Updated player for setting audio and video tracks This pull request is for being able to set video and audio tracks and is part of Servo issue [22799](servo/servo#22799). Servo should be able to set multiple audio tracks at one time but the work here only allows for one. If anyone has any advice on how to set multiple audio tracks that would be great!
☀️ Test successful - checks-travis |
There's previous work done to play multiple audio tracks simultaneously with https://mozilla.logbot.info/servo-media/20190911#c16606524-c16606984 |
Ahh interesting. I am not too familiar with how the GStreamer plugins are done in servo media and I am assuming audiomixer is a plugin here. Could you point me in the general direction of where this is done or how it could be done in servo media if you don't mind? |
https://coaxion.net/blog/2013/11/synchronized-audio-mixing-in-gstreamer/ has a little bit of information about the audiomixer plugin and how it can fit into a gstreamer audio pipeline. |
This pull request is for being able to set video and audio tracks and is part of Servo issue 22799.
Servo should be able to set multiple audio tracks at one time but the work here only allows for one. If anyone has any advice on how to set multiple audio tracks that would be great!