Revert "Add async dispatch event flag to Chromedriver perform action" #18969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsnedders
approved these changes
Sep 10, 2019
|
To clarify: changing tests that are intended to check that a specific message sent over the wire results in specific behaviour in the browser to instead send meaningfully different messages over the wire is inherently a breaking change. The fact that the extra parameters should be ignored by conforming implementations is immaterial. Indeed the only possible valid test in this case would be one that checked this parameter didn't have any effect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks the wdspec tests by causing them to send a nonstandard payload for actions.