Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.z3-solver: init at 4.8.5.0 #68430

Closed
wants to merge 1 commit into from
Closed

pythonPackages.z3-solver: init at 4.8.5.0 #68430

wants to merge 1 commit into from

Conversation

Pamplemousse
Copy link
Member

Motivation for this change

I am trying to make angr, the binary analysis framework, available on NixOS.
This is part of the modules it requires.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable seems to work
leaf package

@kira-bruneau
Copy link
Contributor

kira-bruneau commented Sep 12, 2019 •
edited

It looks like this duplicates the existing z3 python package. It should probably be renamed to z3-solver, since another completely unrelated package called z3 exists in PyPI, which may be confusing.

@lheckemann lheckemann added this to the 20.03 milestone Sep 12, 2019
@Pamplemousse
Copy link
Member Author

@MetaDark Oh right, I missed the fact that the hard work has been already done...

Trying out the existing z3 with the rest of my angr expressions.
Will close if this is not needed.

@Pamplemousse Pamplemousse mentioned this pull request Sep 12, 2019
Closed
@FRidh FRidh self-assigned this Sep 13, 2019
FRidh
FRidh reviewed Sep 13, 2019
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

z3 already exists. Do we need this additional package?

pkgs/development/python-modules/z3-solver/default.nix
pname = "z3-solver";
version = "4.8.5.0";

src = fetchPypi {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please include a link to the actual source in the correct repo/branch. It seems quite hard to find it.

@FRidh
Copy link
Member

FRidh commented Nov 15, 2019

@Pamplemousse will you continue with this? As mentioned, it looks like z3 is already present.

@Pamplemousse
Copy link
Member Author

Pamplemousse commented Nov 15, 2019 •
edited

@FRidh Not anytime soon.

Z3 is already present, but some developpers behind angr host a specific package on PyPi.
Not willing to inverstigate further what the differences are (and if the current Z3 in nixpkgs is up to the job) for now.

Closing, will re-open if I ever want to dig into this.

@Pamplemousse Pamplemousse deleted the z3-solver branch August 11, 2021 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@jonringer jonringer jonringer approved these changes

Assignees

@FRidh FRidh

Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Pamplemousse @kira-bruneau @FRidh @jonringer @lheckemann