Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pivy: fix build #68433

Merged
merged 1 commit into from Sep 10, 2019
Merged

pythonPackages.pivy: fix build #68433

merged 1 commit into from Sep 10, 2019

Conversation

gebner
Copy link
Member

@gebner gebner commented Sep 10, 2019

Motivation for this change

ZHF #68361

I have absolutely no idea what changed so that we now need to disable qmake and cmake explicitly. Anyway, it builds now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@gebner gebner requested a review from FRidh as a code owner September 10, 2019 16:38
@gebner gebner merged commit a9b1f44 into NixOS:master Sep 10, 2019
@gebner
Copy link
Member Author

gebner commented Sep 10, 2019

Backported as 31c5751

@FRidh
Copy link
Member

FRidh commented Sep 10, 2019 via email

@gebner
Copy link
Member Author

gebner commented Sep 11, 2019

Thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gebner @FRidh