Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MathML: check that determination of space-like is done from in-flow c… #18991

Merged
merged 1 commit into from Sep 11, 2019

Conversation

fred-wang
Copy link
Contributor

…hildren

This is a follow-up of #18990 but for space-like elements.
It also introduces helper to navigate in-flow children and properly use
it in the space-like and embellished-op tests.

…hildren

    This is a follow-up of #18990 but for space-like elements.
    It also introduces helper to navigate in-flow children and properly use
    it in the space-like and embellished-op tests.
@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request besides its author. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

Copy link
Contributor

@rwlbuis rwlbuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fred-wang fred-wang merged commit aa2d6a5 into master Sep 11, 2019
@fred-wang fred-wang deleted the space-like-in-flow branch September 11, 2019 13:05
@@ -0,0 +1,22 @@
function IsInFlow(element) {
var style = window.getComputedStyle(child);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should have been element. Will fix in a follow-up commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants