Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: solvespace/solvespace
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 219df31c53f3
Choose a base ref
...
head repository: solvespace/solvespace
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a0e992374dea
Choose a head ref
  • 3 commits
  • 9 files changed
  • 1 contributor

Commits on Sep 11, 2019

  1. Don't call static methods through an instance. NFC. 

    Found by clang-tidy.
    @rpavlik @whitequark
    rpavlik authored and whitequark committed Sep 11, 2019
    Copy the full SHA
    34dccbf View commit details

  2. Use emplace_back. NFC. 

    Found by clang-tidy.
    @rpavlik @whitequark
    rpavlik authored and whitequark committed Sep 11, 2019

    Partially verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
    Copy the full SHA
    ae417fc View commit details

  3. Clean up virtual, override, default, and void params. NFC. 

    Found by clang-tidy.
    @rpavlik @whitequark
    rpavlik authored and whitequark committed Sep 11, 2019

    Partially verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
    Copy the full SHA
    a0e9923 View commit details
Loading