Update wpt scroll-to-visible-areas tests #19007
Conversation
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1795308
branch
3 times, most recently
from
f1d6500
to
fb9ff8c
Compare
The original tests were based on an inaccurate understanding of "visibility" for a snap area, where a snap area was considered to be visible if it is in the viewport at the scroll location before the snap. The definition of visibility per the specification is that a snap area is visible if it would be in the viewport at its snap point. See: w3c/csswg-drafts#2526 (comment) Also added tests for the consideration of scroll-margin when calculating visibility as well. Bug: 954851 Change-Id: Ic2ffef8d02fc5ea2439054b6ea5185bb66622d1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795308 Commit-Queue: Kaan Alsan <alsan@google.com> Reviewed-by: Yi Gu <yigu@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#696435}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1795308
branch
from
fb9ff8c
to
5071831
Compare
|
@hiikezoe FYI, in this PR we have updated some of the scroll-margin tests as it related to snapping and I believe we have discovered a bug in Firefox implementation. Here is some more details:
|
|
Thank you, @majido! That's an interesting test case. Indeed the current Firefox implementation is broken in such cases. (We probably need to drop the old scroll snap implementation completely before fixing this issue) |
The original tests were based on an inaccurate understanding of
"visibility" for a snap area, where a snap area was considered to be
visible if it is in the viewport at the scroll location before the
snap. The definition of visibility per the specification is that a snap
area is visible if it would be in the viewport at its snap point.
See:
w3c/csswg-drafts#2526 (comment)
Also added tests for the consideration of scroll-margin when
calculating visibility as well.
Bug: 954851
Change-Id: Ic2ffef8d02fc5ea2439054b6ea5185bb66622d1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795308
Commit-Queue: Kaan Alsan <alsan@google.com>
Reviewed-by: Yi Gu <yigu@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696435}