[LayoutNG] Fix what replaced elements resolve their block-size against. #19006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 11, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1793942
branch
2 times, most recently
from
93d78ed
to
a18b759
Compare
Previously if we had a table-cell which was %-block-size based, replaced elements would resolve their percentages against this height during both the "measure" and "layout" phases. This was incorrect, instead during the measure phase we should only resolve a percentage against a "fixed" height table-cell, and indefinite for all other cases. Bug: 1001083 Change-Id: If4217a7545830d1279911753930bf821c2c023d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793942 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#695809}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1793942
branch
from
a18b759
to
2505fef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if we had a table-cell which was %-block-size based,
replaced elements would resolve their percentages against this height
during both the "measure" and "layout" phases.
This was incorrect, instead during the measure phase we should only
resolve a percentage against a "fixed" height table-cell, and indefinite
for all other cases.
Bug: 1001083
Change-Id: If4217a7545830d1279911753930bf821c2c023d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793942
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695809}