Reland "[css-grid] Clear the override width for computing percent margins" #18979
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reland of a445d168b9f54cc8902f8bac8da3bc490e441059..
The original patch has been reverted due to a performance regression,
described in bug #1002700.
Additionally, this patch solves some cases not covered by the original patch,
specifically when using 'non-auto' values for the grid item's min-width
property. It also provides additional regressions tests.
Finally, the performance regression is solved by checking out whether the
grid item needs layout before considering to clear the Override size.
Original change's description:
Bug: 834643, 942811
Change-Id: Id6fdf52fab471ebefecb2c087c086faf0e3f5dec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796323
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#699290}