zeroc-ice-36: fix build for gcc8 #68461
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The build was broken failing on unneccessary memsets.
This issue was fixed upstream in 3.7 and discussed in
zeroc-ice/ice#82
The patch pertaining to the error causing the actual failure still
applies nicely onto the 3.6 version.
Hydra logs of breakage: https://hydra.nixos.org/build/100440955/nixlog/1
This is supposed to unblock some downstream builds, like
murmur
in the context of#68361
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @abbradar