New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openjdk8: use lndir instead of single symlink to JRE #68442
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Directly symlinking from the JDK to the JRE confused Gradle and made it try to find JDK files inside the JRE.
10 tasks
I'm going to build 1-2 of the hadoop versions affected with this fix and will report back. |
Tried hadoop 2.7 and 3.1 and they compile fine on NixOS-x86_64. 👍 |
I've pushed this to master as 72f76fe. When it's OK this needs to be backported. Keeping open so we keep track of it. |
ofborg
bot
added
6.topic: GNOME
GNOME desktop environment and its underlying platform
6.topic: haskell
6.topic: lua
6.topic: python
6.topic: qt/kde
6.topic: ruby
8.has: documentation
10.rebuild-darwin-stdenv
10.rebuild-linux-stdenv
8.has: package (new)
10.rebuild-darwin: 501+
and removed
6.topic: GNOME
GNOME desktop environment and its underlying platform
6.topic: haskell
6.topic: lua
6.topic: python
6.topic: qt/kde
6.topic: ruby
8.has: documentation
labels
Sep 10, 2019
ofborg
bot
added
10.rebuild-darwin: 5001+
10.rebuild-linux: 501+
10.rebuild-linux: 5001+
10.rebuild-darwin: 0
10.rebuild-linux: 101-500
and removed
10.rebuild-darwin: 0
10.rebuild-linux: 101-500
10.rebuild-darwin-stdenv
10.rebuild-linux-stdenv
10.rebuild-darwin: 501+
10.rebuild-darwin: 5001+
10.rebuild-linux: 501+
10.rebuild-linux: 5001+
labels
Sep 10, 2019
I can also confirm, this fixes my gradle builds. Thank you! |
Seems like its doing fine on master. |
Will cherry-pick and build on 19.09 now. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes gradle based packages (and others) that were broken by #68382, by reverting to the prior symlinking strategy using
lndir
.I also think this will supersede #68382, as it fixes jogl and hadoop.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)cc @fgaz @d-goldin