Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openjdk8: use lndir instead of single symlink to JRE #68442

Closed
wants to merge 1 commit into from

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

Fixes gradle based packages (and others) that were broken by #68382, by reverting to the prior symlinking strategy using lndir.

I also think this will supersede #68382, as it fixes jogl and hadoop.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @fgaz @d-goldin

Directly symlinking from the JDK to the JRE confused Gradle and made it try to
find JDK files inside the JRE.
@d-goldin
Copy link
Contributor

I'm going to build 1-2 of the hadoop versions affected with this fix and will report back.

@d-goldin
Copy link
Contributor

Tried hadoop 2.7 and 3.1 and they compile fine on NixOS-x86_64. 👍

@FRidh FRidh added this to the 19.09 milestone Sep 10, 2019
@FRidh FRidh changed the base branch from staging to master September 10, 2019 20:19
@FRidh FRidh changed the base branch from master to staging September 10, 2019 20:19
@FRidh
Copy link
Member

FRidh commented Sep 10, 2019

I've pushed this to master as 72f76fe. When it's OK this needs to be backported. Keeping open so we keep track of it.

@fgaz
Copy link
Member

fgaz commented Sep 11, 2019

I can also confirm, this fixes my gradle builds. Thank you!

@d-goldin
Copy link
Contributor

Seems like its doing fine on master.

@lheckemann
Copy link
Member

Will cherry-pick and build on 19.09 now.

@lheckemann lheckemann closed this Sep 13, 2019
@lopsided98 lopsided98 deleted the openjdk8-fix-gradle branch September 13, 2019 15:16
@lheckemann
Copy link
Member

3575160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants