Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

morph: 1.3.0 -> 1.3.1 #68439

Merged
merged 1 commit into from Sep 11, 2019
Merged

morph: 1.3.0 -> 1.3.1 #68439

merged 1 commit into from Sep 11, 2019

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Sep 10, 2019

Motivation for this change

#68421 into 19.09

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@mmahut
Copy link
Member Author

mmahut commented Sep 10, 2019

We will wait until @GrahamcOfBorg is up again to make sure this builds on other platforms too.

ivan
ivan approved these changes Sep 11, 2019
View reviewed changes
Copy link
Member

@ivan ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built and tested this on NixOS x86_64 and it is working fine (tested: morph deploy).

@mmahut
Copy link
Member Author

mmahut commented Sep 11, 2019

@GrahamcOfBorg build morph

Borgy sleepy borg, wake up.

@mmahut
Copy link
Member Author

mmahut commented Sep 11, 2019

Well, it builds in hydra for master.

@mmahut mmahut merged commit 231544c into NixOS:release-19.09 Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan ivan ivan approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmahut @ivan