Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support inline sessions in WebXR #24186

Closed
Manishearth opened this issue Sep 11, 2019 · 3 comments · Fixed by #25144
Closed

Support inline sessions in WebXR #24186

Manishearth opened this issue Sep 11, 2019 · 3 comments · Fixed by #25144
Assignees
@Manishearth
Labels
A-xr-spec-complete Things necessary to support the full WebXR spec A-xr-zomg AR/VR/MR

Comments

@Manishearth
Copy link
Member

Manishearth commented Sep 11, 2019 •
edited

We currently only support immersive sessions.

This may be easier to do once servo/webxr#30 is solved.

Diorama sessions are currently not supported by the spec, so this may not be that hard to support.

This also includes support for https://immersive-web.github.io/webxr/#dom-xrrenderstate-inlineverticalfieldofview
@Manishearth Manishearth added A-xr-zomg AR/VR/MR A-xr-spec-complete Things necessary to support the full WebXR spec labels Sep 11, 2019
@Manishearth Manishearth mentioned this issue Sep 24, 2019
Merged
@Manishearth
Copy link
Member Author

Thinking about the design, since webxr cannot support diorama sessions, perhaps the best design for now is to implement these entirely on the DOM side as a different codepath which uses the window's rAF tick?

This does mean inline sessions with spatial tracking will still not be possible, but that needs servo/webxr#30 .

This would also just make it easier to test XR stuff.

@Manishearth
Copy link
Member Author

cc @asajeffrey

@Manishearth Manishearth mentioned this issue Dec 5, 2019
Merged
bors-servo pushed a commit to servo/webxr that referenced this issue Dec 5, 2019
Auto merge of #99 - Manishearth:frustum-cleanup, r=asajeffrey
6d930a0 
Clean up frustum code, export from webxr-api

If we end up implementing inline sessions purely in servo (servo/servo#24186), these functions will be useful.

r? @asajeffrey
@asajeffrey
Copy link
Member

This makes servo/webxr#30 a higher-priority item.

@Manishearth Manishearth self-assigned this Dec 5, 2019
@Manishearth Manishearth mentioned this issue Dec 5, 2019
Merged
3 tasks
bors-servo pushed a commit that referenced this issue Dec 6, 2019
Auto merge of #25144 - Manishearth:inline, r=asajeffrey
77364e8 
Support inline sessions (with spatial tracking!)

This assumes that your WebXR backend can tolerate being spawned multiple times in inline mode. Currently there is only one backend that allows inline mode (headless), and it works there. This can be improved with servo/webxr#30 .

Todo:

 - [ ] Add a default inline device to webxr so that there is always a tracking-free inline session available (followup: servo/webxr#101)
 - [x] WPT update
 - [ ] Make inline with spatial tracking a feature request (followup: #24270)

fixes #24186

Depends on servo/webxr#100
bors-servo pushed a commit that referenced this issue Dec 6, 2019
Auto merge of #25144 - Manishearth:inline, r=asajeffrey
07aeb87 
Support inline sessions (with spatial tracking!)

This assumes that your WebXR backend can tolerate being spawned multiple times in inline mode. Currently there is only one backend that allows inline mode (headless), and it works there. This can be improved with servo/webxr#30 .

Todo:

 - [ ] Add a default inline device to webxr so that there is always a tracking-free inline session available (followup: servo/webxr#101)
 - [x] WPT update
 - [ ] Make inline with spatial tracking a feature request (followup: #24270)

fixes #24186

Depends on servo/webxr#100
bors-servo pushed a commit that referenced this issue Dec 11, 2019
Auto merge of #25144 - Manishearth:inline, r=asajeffrey
5bc0f92 
Support inline sessions (with spatial tracking!)

This assumes that your WebXR backend can tolerate being spawned multiple times in inline mode. Currently there is only one backend that allows inline mode (headless), and it works there. This can be improved with servo/webxr#30 .

Todo:

 - [ ] Add a default inline device to webxr so that there is always a tracking-free inline session available (followup: servo/webxr#101)
 - [x] WPT update
 - [ ] Make inline with spatial tracking a feature request (followup: #24270)

fixes #24186

Depends on servo/webxr#100
bors-servo pushed a commit that referenced this issue Dec 11, 2019
Auto merge of #25144 - Manishearth:inline, r=<try>
47293be 
Support inline sessions (with spatial tracking!)

This assumes that your WebXR backend can tolerate being spawned multiple times in inline mode. Currently there is only one backend that allows inline mode (headless), and it works there. This can be improved with servo/webxr#30 .

Todo:

 - [ ] Add a default inline device to webxr so that there is always a tracking-free inline session available (followup: servo/webxr#101)
 - [x] WPT update
 - [ ] Make inline with spatial tracking a feature request (followup: #24270)

fixes #24186

Depends on servo/webxr#100
bors-servo pushed a commit that referenced this issue Dec 11, 2019
Auto merge of #25144 - Manishearth:inline, r=asajeffrey
50cfa4d 
Support inline sessions (with spatial tracking!)

This assumes that your WebXR backend can tolerate being spawned multiple times in inline mode. Currently there is only one backend that allows inline mode (headless), and it works there. This can be improved with servo/webxr#30 .

Todo:

 - [ ] Add a default inline device to webxr so that there is always a tracking-free inline session available (followup: servo/webxr#101)
 - [x] WPT update
 - [ ] Make inline with spatial tracking a feature request (followup: #24270)

fixes #24186

Depends on servo/webxr#100
bors-servo pushed a commit that referenced this issue Dec 11, 2019
Auto merge of #25144 - Manishearth:inline, r=asajeffrey
4393cfe 
Support inline sessions (with spatial tracking!)

This assumes that your WebXR backend can tolerate being spawned multiple times in inline mode. Currently there is only one backend that allows inline mode (headless), and it works there. This can be improved with servo/webxr#30 .

Todo:

 - [ ] Add a default inline device to webxr so that there is always a tracking-free inline session available (followup: servo/webxr#101)
 - [x] WPT update
 - [ ] Make inline with spatial tracking a feature request (followup: #24270)

fixes #24186

Depends on servo/webxr#100
bors-servo pushed a commit that referenced this issue Dec 11, 2019
Auto merge of #25144 - Manishearth:inline, r=asajeffrey
16e1211 
Support inline sessions (with spatial tracking!)

This assumes that your WebXR backend can tolerate being spawned multiple times in inline mode. Currently there is only one backend that allows inline mode (headless), and it works there. This can be improved with servo/webxr#30 .

Todo:

 - [ ] Add a default inline device to webxr so that there is always a tracking-free inline session available (followup: servo/webxr#101)
 - [x] WPT update
 - [ ] Make inline with spatial tracking a feature request (followup: #24270)

fixes #24186

Depends on servo/webxr#100
bors-servo pushed a commit that referenced this issue Dec 12, 2019
Auto merge of #25144 - Manishearth:inline, r=asajeffrey
232237f 
Support inline sessions (with spatial tracking!)

This assumes that your WebXR backend can tolerate being spawned multiple times in inline mode. Currently there is only one backend that allows inline mode (headless), and it works there. This can be improved with servo/webxr#30 .

Todo:

 - [ ] Add a default inline device to webxr so that there is always a tracking-free inline session available (followup: servo/webxr#101)
 - [x] WPT update
 - [ ] Make inline with spatial tracking a feature request (followup: #24270)

fixes #24186

Depends on servo/webxr#100
bors-servo pushed a commit that referenced this issue Dec 12, 2019
Auto merge of #25144 - Manishearth:inline, r=asajeffrey
208faf6 
Support inline sessions (with spatial tracking!)

This assumes that your WebXR backend can tolerate being spawned multiple times in inline mode. Currently there is only one backend that allows inline mode (headless), and it works there. This can be improved with servo/webxr#30 .

Todo:

 - [ ] Add a default inline device to webxr so that there is always a tracking-free inline session available (followup: servo/webxr#101)
 - [x] WPT update
 - [ ] Make inline with spatial tracking a feature request (followup: #24270)

fixes #24186

Depends on servo/webxr#100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Manishearth Manishearth

Labels
A-xr-spec-complete Things necessary to support the full WebXR spec A-xr-zomg AR/VR/MR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support inline sessions (with spatial tracking!) Manishearth/servo
2 participants
@asajeffrey @Manishearth