Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that the rejection of the ready promise when calling cancel() does not cause a harness error #19001

Merged
merged 1 commit into from Sep 11, 2019
Merged

Ensure that the rejection of the ready promise when calling cancel() does not cause a harness error #19001

merged 1 commit into from Sep 11, 2019

Conversation

graouts
Copy link
Contributor

@graouts graouts commented Sep 11, 2019

This addresses issue #18932.

flackr
flackr approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@flackr flackr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graouts graouts merged commit fa351d7 into web-platform-tests:master Sep 11, 2019
@graouts graouts deleted the issue-18932 branch September 11, 2019 16:35
@foolip foolip mentioned this pull request Sep 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flackr flackr flackr approved these changes

@stephenmcgruer stephenmcgruer Awaiting requested review from stephenmcgruer

@birtles birtles Awaiting requested review from birtles

Assignees

@stephenmcgruer stephenmcgruer

Labels
web-animations wg-css wg-svg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@graouts @flackr @stephenmcgruer @wpt-pr-bot @moz-wptsync-bot