Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.mulpyplexer: init at 0.08 #68429

Closed
wants to merge 1 commit into from
Closed

pythonPackages.mulpyplexer: init at 0.08 #68429

wants to merge 1 commit into from

Conversation

Pamplemousse
Copy link
Member

Motivation for this change

I am trying to make angr, the binary analysis framework, available on NixOS.
This is part of the modules it requires.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM

no tests, but repo doesn't have tests :(
I would say, "As good as the pypi package" :)

@lheckemann lheckemann added this to the 20.03 milestone Sep 12, 2019
@Pamplemousse
Copy link
Member Author

I started https://github.com/angr/nixpkgs , and it should be added to NUR following nix-community/NUR#160.
Closed as an angr related package.

@Pamplemousse Pamplemousse deleted the mulpyplexer branch December 13, 2019 16:01
@fabaff fabaff mentioned this pull request Jan 10, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pamplemousse @jonringer @lheckemann