Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing to restart browser doesn't fail job #18966

Closed
gsnedders opened this issue Sep 10, 2019 · 0 comments · Fixed by #18967
Closed

Failing to restart browser doesn't fail job #18966

gsnedders opened this issue Sep 10, 2019 · 0 comments · Fixed by #18967
Assignees
@gsnedders
Labels
infra wptrunner The automated test runner, commonly called through ./wpt run
Projects
Reliable Safari results

Comments

@gsnedders
Copy link
Member

This is still true despite #14604 landing. Presumably this error isn't critical.
@gsnedders gsnedders added infra wptrunner The automated test runner, commonly called through ./wpt run labels Sep 10, 2019
@gsnedders gsnedders self-assigned this Sep 10, 2019
@gsnedders gsnedders added this to To do in Reliable Safari results via automation Sep 10, 2019
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Sep 10, 2019
@gsnedders
Fix web-platform-tests#18966: Upgrade various ERRORs to CRITICAL
c56ef27 
All of these are cases where we abort the world, so they're kinda
critical I'd say.
@gsnedders gsnedders mentioned this issue Sep 10, 2019
Merged
Reliable Safari results automation moved this from To do to Done Sep 10, 2019
gsnedders added a commit that referenced this issue Sep 10, 2019
@gsnedders
Fix #18966: Upgrade various ERRORs to CRITICAL (#18967)
48d9218 
All of these are cases where we abort the world, so they're kinda
critical I'd say.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsnedders gsnedders

Labels
infra wptrunner The automated test runner, commonly called through ./wpt run
Projects
Reliable Safari results
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #18966: Upgrade various ERRORs to CRITICAL gsnedders/web-platform-tests
1 participant
@gsnedders