Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.cooldict: init at unstable-2019-10-29 #68428

Closed
wants to merge 1 commit into from
Closed

pythonPackages.cooldict: init at unstable-2019-10-29 #68428

wants to merge 1 commit into from
+31 −0

Conversation

Pamplemousse
Copy link
Member

Motivation for this change

I am trying to make angr, the binary analysis framework, available on NixOS.
This is part of the modules it requires.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Pamplemousse Pamplemousse requested a review from FRidh as a code owner September 10, 2019 15:49
@ofborg ofborg bot added 6.topic: python 2.status: merge conflict This PR has merge conflicts with the target branch labels Sep 10, 2019
@Pamplemousse Pamplemousse force-pushed the cooldict branch 2 times, most recently from 3d20a7a to 3b7fb96 Compare September 10, 2019 16:13
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 10, 2019
@Pamplemousse Pamplemousse changed the title pythonPackages.cooldict: init at 1.04 [WIP] pythonPackages.cooldict: init at 1.04 Sep 10, 2019
@Pamplemousse
Copy link
Member Author

Pamplemousse commented Sep 10, 2019 •
edited
Loading

Waiting for cooldict to remove its dependency on ana: zardus/cooldict#11 .

As of now, cooldict has a requirement on ana.

However, this should not be the case, and should be fixed; See issue referenced above.

For this package to build, I wrote an expression to have the ana package locally (as in #68426).

@lheckemann lheckemann added this to the 20.03 milestone Sep 12, 2019
@Pamplemousse Pamplemousse changed the title [WIP] pythonPackages.cooldict: init at 1.04 pythonPackages.cooldict: init at unstable-2019-10-29 Oct 30, 2019
@Pamplemousse
Copy link
Member Author

Finally, cooldict removed its requiment on ana.

@jonringer , @FRidh , ready for review :)

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 30, 2019
jonringer
jonringer reviewed Nov 14, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this package im less thrilled at adding to nixpkgs,

  • very little activity/usage on github
  • no tests
  • no releases
  • unhelpful readme

I would put it into NUR

@Pamplemousse
Copy link
Member Author

I am working on trying to get angr in nixpkgs (see #67413), and cooldict is one of its (home-made) component.

  • very little activity/usage on github: On this package as such yes, but angr is very active.
  • no releases: Actually, releases are numbered on PyPi.
  • no tests
  • unhelpful readme

I think this imply a broader discussion, moving to #67413 .

@Pamplemousse Pamplemousse mentioned this pull request Nov 14, 2019
Closed
@Pamplemousse
Copy link
Member Author

angr remove its dependency to cooldict! angr/angr@aace252

I have added to my NUR repo: https://github.com/Pamplemousse/nur-packages/commit/f66e3161595f988c4337f6336e1de2f2e8bffec6 .

@Pamplemousse Pamplemousse deleted the cooldict branch August 11, 2021 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pamplemousse @jonringer @lheckemann