Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #18966: Upgrade various ERRORs to CRITICAL #18967

Merged
merged 1 commit into from Sep 10, 2019

Conversation

gsnedders
Copy link
Member

@gsnedders gsnedders commented Sep 10, 2019

All of these are cases where we abort the world, so they're kinda
critical I'd say.

Fixes #18966.

All of these are cases where we abort the world, so they're kinda
critical I'd say.
@wpt-pr-bot wpt-pr-bot added infra wpt wptrunner The automated test runner, commonly called through ./wpt run wptserve labels Sep 10, 2019
@gsnedders gsnedders added this to To do in Reliable Safari results via automation Sep 10, 2019
Copy link
Contributor

@jgraham jgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could argue some of these, but I guess the principle that there should always be a critical level message if we are about to exit with status != 0 is pretty sound.

@gsnedders gsnedders merged commit 48d9218 into web-platform-tests:master Sep 10, 2019
Reliable Safari results automation moved this from To do to Done Sep 10, 2019
@gsnedders gsnedders deleted the error-to-critical branch September 10, 2019 16:11
@foolip
Copy link
Member

foolip commented Sep 11, 2019

This appears to have caused both Safari (#18995) and Edge (#19005) runs to start failing.

The underlying problem was presumably already there and uncovering it is good, but this change would have benefited from triggering full runs before landing on master. That would have avoided the need to rush to fix these issues.

At this point I don't think that reverting this is necessary, but if the Safari runs are still failing it might be the best way to recover.

@gsnedders
Copy link
Member Author

@foolip I did do a full run of STP before landing, FWIW.

@foolip
Copy link
Member

foolip commented Sep 12, 2019

Weird, it seemed like a persistent failure. Perhaps the real cause for this snuck in in between your testing and landing? Can you check git log and see if anything stands out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra wpt wptrunner The automated test runner, commonly called through ./wpt run wptserve
Projects
Development

Successfully merging this pull request may close these issues.

Failing to restart browser doesn't fail job
5 participants