Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.itanium_demangler: init at 1.0 #68425

Merged
merged 1 commit into from
Nov 13, 2019
Merged

pythonPackages.itanium_demangler: init at 1.0 #68425

merged 1 commit into from
Nov 13, 2019
+32 −0

Conversation

Pamplemousse
Copy link
Member

Motivation for this change

I am trying to make angr, the binary analysis framework, available on NixOS.
This is part of the modules it requires.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Pamplemousse Pamplemousse requested a review from FRidh as a code owner September 10, 2019 15:46
@ofborg ofborg bot added 6.topic: python 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 10, 2019
jonringer
jonringer reviewed Sep 10, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no tests are shipped with the pypi package, please checkout the src from https://github.com/whitequark/python-itanium_demangler please :)

@Pamplemousse
Copy link
Member Author

Pamplemousse commented Sep 10, 2019 •
edited
Loading

Sill, there were no tests executing...

So now, the expression:

  • Uses fetchFromGitHub;
  • Has a checkPhase to do pytest tests/test.py.

jonringer
jonringer approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM (1 suggestion/comment)
leaf package

@Pamplemousse
Copy link
Member Author

I don't understand why the grahamcofborg-eval-check-meta and grahamcofborg-eval are failing...

@jonringer
Copy link
Contributor

the eval-check-meta is not related to this package, the normal eval I have no idea

They are doing a lot of changes to try and cut nixpkgs19.09, something probably slipped through and broke everything :)

@lheckemann lheckemann added this to the 20.03 milestone Sep 12, 2019
@Pamplemousse
Copy link
Member Author

@GrahamcOfBorg test

@jonringer
Copy link
Contributor

do you mind rebasing to get rid of conflicts?

git pull -r origin master
# deal with conflicts

@Pamplemousse
Copy link
Member Author

Did not realise there were conflicts ^^

jonringer
jonringer approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
commits LGTM

[5 built, 9 copied (5.0 MiB), 0.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/68425
3 package were build:
python27Packages.itanium_demangler python37Packages.itanium_demangler python38Packages.itanium_demangler

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.itanium_demangler python37Packages.itanium_demangler python38Packages.itanium_demangler

jonringer
jonringer approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
commits LGTM

[5 built, 9 copied (5.0 MiB), 0.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/68425
3 package were build:
python27Packages.itanium_demangler python37Packages.itanium_demangler python38Packages.itanium_demangler

@jonringer
Copy link
Contributor

oh lol, forgot i already approved xD

@jonringer jonringer merged commit 02583ed into NixOS:master Nov 13, 2019
@Pamplemousse Pamplemousse deleted the itanium_demangler branch August 11, 2021 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pamplemousse @jonringer @lheckemann