Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pytest: Revert "4.6.5 -> 5.1.0 in case of Python 3" #68436

Closed
wants to merge 1 commit into from

Conversation

peti
Copy link
Member

@peti peti commented Sep 10, 2019

This reverts commit b3ddab8. The update broke
a number of other packages, like python-blessed and python-django-extentsions,
which are dependencies of GNU Mailman.

Ping @FRidh.

@peti peti requested a review from FRidh as a code owner September 10, 2019 17:47
This reverts commit b3ddab8. The update broke
a number of other packages, like python-blessed and python-django-extentsions,
which are dependencies of GNU Mailman.

Ping @FRidh.
@peti peti added 0.kind: regression Something that worked before working no longer 6.topic: python labels Sep 10, 2019
@jonringer
Copy link
Contributor

The better solution be to just disable the tests that aren't compatible.

This will likely break packages that are using pytest5 features.

@jonringer
Copy link
Contributor

Also, python doesn't handle mutliple versions well, since they have to coexist in the same environment. There should only ever be a single version of a package for an interpreter version.

@peti
Copy link
Member Author

peti commented Sep 10, 2019

The better solution be to just disable the tests that aren't compatible.

Well, after we've reverted the update, then we can disable those test suites that turn out to depend on pytest-5.x features.

@FRidh
Copy link
Member

FRidh commented Sep 10, 2019

This is a mass rebuild. The far majority of packages are already compatible or have been adjusted. Those that need fixing can be done now and backported to 19.09. Also, reverting will break other packages.

@FRidh
Copy link
Member

FRidh commented Sep 10, 2019

I've fixed the two mentioned packages on master and 19.09.

@FRidh FRidh closed this Sep 10, 2019
@FRidh
Copy link
Member

FRidh commented Sep 10, 2019

4dd38c4
aa6c38d

@peti
Copy link
Member Author

peti commented Sep 10, 2019

I reverted the first commit. I had fixed the test suite already in 26771ad.

@peti
Copy link
Member Author

peti commented Sep 10, 2019

OK, thank you for the fix for django-extensions. I'll check how far I get now compiling Mailman.

@peti peti deleted the t/revert-pytest-update branch September 10, 2019 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants