Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser window stays maximized after exiting fullscreen mode #24200

Closed
ferjm opened this issue Sep 12, 2019 · 1 comment · Fixed by #24249
Closed

Browser window stays maximized after exiting fullscreen mode #24200

ferjm opened this issue Sep 12, 2019 · 1 comment · Fixed by #24249

Comments

@ferjm
Copy link
Contributor

ferjm commented Sep 12, 2019

STR:

Expected:

  • Clicking on the Hide Fullscreen button minimizes the browser and changes the background color back to white.

Current behaviour:

  • Clicking on the Hide Fullscreen button changes the background color back to white, but the browser stays maximized.
@jdm
Copy link
Member

jdm commented Sep 12, 2019

I think the problem is this line.

bors-servo pushed a commit that referenced this issue Sep 20, 2019
Go back to original window size after exiting fullscreen

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #24200

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24249)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Sep 20, 2019
Go back to original window size after exiting fullscreen

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #24200

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24249)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants