Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zcash: Add libsnark to stop build failures #68535

Merged
merged 1 commit into from Sep 16, 2019
Merged

zcash: Add libsnark to stop build failures #68535

merged 1 commit into from Sep 16, 2019

Conversation

craigem
Copy link
Contributor

@craigem craigem commented Sep 12, 2019

Motivation for this change

Wanted for #68361

zcash build fails due to missing profiling.hpp which is provided bylibsnark.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @rht

@craigem
zcash: Add libsnark to stop build failures
2c9bab7 
Wanted for NixOS#68361

zcash build fails due to missing `profiling.hpp` which is provided by
`libsnark`.
@rht
Copy link
Member

rht commented Sep 12, 2019

@craigem what is the error specifically? The current master buiilds just fine on my machine, and zcashd runs without error. Is it perhaps required by the tests (since it is profiling.hpp after all)?

@lheckemann lheckemann added this to the 19.09 milestone Sep 12, 2019
@craigem
Copy link
Contributor Author

craigem commented Sep 12, 2019

Great question @rht and I ought to have included it in the original report.

The failure can be seen on https://hydra.nixos.org/build/100607516/nixlog/2 in the staging-19.09 build 100607516 of evaluation 1541899.

I've not yet had a chance to follow up on other evaluations.

@rht
Copy link
Member

rht commented Sep 13, 2019

Tagging @worldofpeace for an ofborg build.

@worldofpeace
Copy link
Contributor

Tagging @worldofpeace for an ofborg build.

ofborg is currently "out of order" so I'll QA this locally.

@worldofpeace worldofpeace merged commit 7bbce4a into NixOS:master Sep 16, 2019
@worldofpeace
Copy link
Contributor

backported ea765f5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
19.09
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@craigem @rht @worldofpeace @lheckemann