Render android #308
Merged
Render android #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since they are already especified when loaded by platform in the GStreamerRender object.
ceyusa
force-pushed
the
render-android
branch
6 times, most recently
from
5bab635
to
3047ced
Compare
|
Sadly, we don't have a test for android rendering gl textures. We need to test it in Servo directly. |
|
I'll test it with Servo as soon as possible |
ceyusa
force-pushed
the
render-android
branch
from
3047ced
to
6e60bca
Compare
|
removed the GL context activation |
|
Can we merge this for now? @ferjm, @asajeffrey ? |
|
Yes, I think we can merge as soon as CI is happy. |
|
Fine by me. it would be nice if we could figure out a way to use features rather than gating on |
ceyusa
force-pushed
the
render-android
branch
from
6e60bca
to
9add8b7
Compare
|
@bors-servo r+ |
|
📌 Commit 9add8b7 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Sep 16, 2019
Render android Add GL render for android target, which is a unix type with only EGL.
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GL render for android target, which is a unix type with only EGL.