Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plyplus: enable for python3 #68527

Merged
merged 1 commit into from Sep 12, 2019
Merged

plyplus: enable for python3 #68527

merged 1 commit into from Sep 12, 2019

Conversation

nspin
Copy link
Contributor

@nspin nspin commented Sep 11, 2019

Motivation for this change

plyplus supports Python 3, but its tests don't.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Ma27 Ma27 merged commit 4bb6905 into NixOS:master Sep 12, 2019
@Ma27
Copy link
Member

Ma27 commented Sep 12, 2019

Backported as 60c1f80

@nspin nspin deleted the pr/plyplus-python3 branch September 24, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants