Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetchRepoProject: add manifestName parameter #68524

Merged
merged 1 commit into from Aug 14, 2020
Merged

fetchRepoProject: add manifestName parameter #68524

merged 1 commit into from Aug 14, 2020

Conversation

nspin
Copy link
Contributor

@nspin nspin commented Sep 11, 2019 •
edited

Motivation for this change

To expose repo's --manifest-name command line argument via fetchRepoProject.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@lheckemann lheckemann added this to the 20.03 milestone Sep 12, 2019
@disassembler disassembler modified the milestones: 20.03, 20.09 Feb 5, 2020
doronbehar
doronbehar approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff lgtm, haven't tested.

@Pamplemousse Pamplemousse mentioned this pull request Aug 13, 2020
Closed
@Pamplemousse
Copy link
Member

LGTM.
Tested on NixOS: option works as expected.

Tried to nix-review, but not much comes out of it (my understanding is that the package does not have dependencies in the current branch - @nspin can you rebase please?).

@Mic92
Copy link
Member

Mic92 commented Aug 14, 2020

LGTM.
Tested on NixOS: option works as expected.

Tried to nix-review, but not much comes out of it (my understanding is that the package does not have dependencies in the current branch - @nspin can you rebase please?).

You can try to change a checksum of some package to trigger an actual rebuild and test if the checksum is still the same.

@Pamplemousse
Copy link
Member

@Mic92

You can try to change a checksum of some package to trigger an actual rebuild

That's what I did to check that the option worked as expected.

[...] test if the checksum is still the same.

Not sure what you refer to by that...

@Mic92 Mic92 merged commit 1f2c19f into NixOS:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

Assignees
No one assigned
Labels
6.topic: fetch 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
20.09
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nspin @Pamplemousse @Mic92 @doronbehar @lheckemann @disassembler