Adding resource timing test that checks for #hash in the URL #19015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly copypasta of the `resource-timing/resource_cached.htm` test Currently the test fails in Safari. Safari seems to strip the hash when it comes to images. XHRs look ok.
wpt-pr-bot
requested review from
igrigorik,
plehegar,
toddreifsteck,
yoavweiss and
zqzhang
|
Thank you for flying WPT! :D I suspect you don't really need the whole iframe setup here, and could easily test the same thing by going to hash_responses.html directly, and running the asserts there. |
using relatively recent features (filter and const), not sure if it's ok
|
The lint bot doesn't like you patch for some reason. Can you run |
./wpt lint resource-timing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly copypasta of the
resource-timing/resource_cached.htmtestCurrently the test fails in Safari. Safari seems to strip the hash when it comes to images. XHRs look ok.