Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maestral: 0.2.6 -> 0.4.0 #68478

Merged
merged 2 commits into from Sep 23, 2019
Merged

maestral: 0.2.6 -> 0.4.0 #68478

merged 2 commits into from Sep 23, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Rapidly changing project...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from lovek323 September 11, 2019 06:14
@peterhoeg peterhoeg mentioned this pull request Sep 11, 2019
Closed
@peterhoeg
Copy link
Member Author

The change to pythonPackages.keyring (apart from the update) is the addition of dbus-python that allows it to talk to kwallet.

@lheckemann lheckemann added this to the 20.03 milestone Sep 12, 2019
@peterhoeg peterhoeg changed the title maestral: 0.2.6 -> 0.3.2 maestral: 0.2.6 -> 0.4.0 Sep 16, 2019
@peterhoeg
Copy link
Member Author

@GrahamcOfBorg build maestral maestral-gui

@worldofpeace
Copy link
Contributor

Fails to build with

Collecting keyring>=19.0.0 (from maestral==0.4.0)
  ERROR: Could not find a version that satisfies the requirement keyring>=19.0.0 (from maestral==0.4.0) (from versions: none)

keyring is out of date.

@peterhoeg
Copy link
Member Author

Nice catch @worldofpeace - I must have overwritten the branch as they commit was here previously.

@peterhoeg
Copy link
Member Author

peterhoeg commented Sep 16, 2019 via email

@peterhoeg peterhoeg merged commit fd3b329 into NixOS:master Sep 23, 2019
@peterhoeg peterhoeg deleted the u/maestral branch September 23, 2019 03:29
@peterhoeg peterhoeg restored the u/maestral branch September 25, 2019 10:28
@peterhoeg peterhoeg deleted the u/maestral branch September 25, 2019 10:53
@peterhoeg peterhoeg restored the u/maestral branch September 26, 2019 13:17
@peterhoeg peterhoeg deleted the u/maestral branch September 26, 2019 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@FRidh FRidh Awaiting requested review from FRidh

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @worldofpeace @lheckemann