Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home-assistant: remove outdated pyyaml_3 pinning #68481

Merged
merged 1 commit into from Sep 12, 2019
Merged

home-assistant: remove outdated pyyaml_3 pinning #68481

merged 1 commit into from Sep 12, 2019

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Sep 11, 2019

Motivation for this change

The recent bump to 0.96.2 now requires pyyaml 5.1.1. The PRs upgrading
home-assistant to a newer version and the one pinning to an old PyYAML
version raced each other and we ended up with both submitted.

Fixes home-assistant build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@delroth
home-assistant: remove outdated pyyaml_3 pinning
04c1fcd 
The recent bump to 0.96.2 now requires pyyaml 5.1.1. The PRs upgrading
home-assistant to a newer version and the one pinning to an old PyYAML
version raced each other and we ended up with both submitted.

Fixes home-assistant build.
@delroth
Copy link
Contributor Author

delroth commented Sep 11, 2019

cc @NixOS/backports since 19.09 has the same issue (https://hydra.nixos.org/eval/1541808?filter=home-assistant&compare=1541751&full=)

@ofborg ofborg bot requested review from dotlambda and globin September 11, 2019 06:58
@peterhoeg
Copy link
Member

Cc @dotlambda

@Mic92 Mic92 added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 11, 2019
@Mic92 Mic92 modified the milestones: 19.09, 20.03 Sep 11, 2019
@lheckemann lheckemann modified the milestones: 20.03, 19.09 Sep 11, 2019
davidak
davidak approved these changes Sep 12, 2019
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(havn't tested tho)

@globin globin merged commit 6ea6c9d into NixOS:master Sep 12, 2019
@davidak davidak mentioned this pull request Sep 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak davidak approved these changes

@FRidh FRidh FRidh approved these changes

@dotlambda dotlambda Awaiting requested review from dotlambda

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
19.09
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@delroth @peterhoeg @davidak @FRidh @Mic92 @lheckemann @globin