Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/shells-environment: Make ~/bin/ in $PATH optional #68483

Merged
merged 1 commit into from Nov 2, 2019
Merged

nixos/shells-environment: Make ~/bin/ in $PATH optional #68483

merged 1 commit into from Nov 2, 2019

Conversation

chkno
Copy link
Member

@chkno chkno commented Sep 11, 2019 •
edited

Motivation for this change

I don't want ~/bin/ in $PATH. Without this new option, I didn't find a way to override setEnvironment to make it stop adding ~/bin/ to PATH without either copy/pasting its implementation into my configs or setting cfg.extraInit = "return"; both of which are very brittle workarounds.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@andir
Copy link
Member

andir commented Sep 12, 2019

@chkno changes look good. Could you squash them together?

@lheckemann lheckemann added this to the 20.03 milestone Sep 12, 2019
@chkno
Copy link
Member Author

chkno commented Sep 12, 2019

I squashed them together and then force-pushed the the pull-request branch. Is that what you meant, or should I have started a new branch?

Thanks!

@andir
Copy link
Member

andir commented Sep 12, 2019 via email

@chkno
Copy link
Member Author

chkno commented Sep 18, 2019

Anything else I should do?

@chkno chkno requested a review from andir September 24, 2019 18:27
@andir
Copy link
Member

andir commented Nov 2, 2019

@chkno Thank you for the change. It looks good 👍.

@andir andir merged commit 5d5b140 into NixOS:master Nov 2, 2019
@andir andir mentioned this pull request Nov 2, 2019
Merged
10 tasks
@chkno chkno deleted the optional-home-bin-in-path branch November 4, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ck3d ck3d ck3d approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

@andir andir Awaiting requested review from andir

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chkno @andir @ck3d @worldofpeace @lheckemann