Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland "Switch InterpolableLength implementation from length array to expression" #19017

Closed
wants to merge 1 commit into from

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 12, 2019

This reverts commit b8229a7b3ecaed4f11210ef512d2c3099f79a33b.

Reason for revert: Fixing performance regression

Original change's description:

Revert "Switch InterpolableLength implementation from length array to expression"

This reverts commit dd1318d7b1537af982313d51433e00fc02421225.

Reason for revert: caused performance regression crbug.com/1002177

Original change's description:

Switch InterpolableLength implementation from length array to expression

This patch changes the internal implementation of InterpolableLength
from CSSLengthArray to the following:

  • A CSSNumericLiteralValue to keep it simple when it's a simple value
  • A CSSMathExpressionNode to make it general when the underlying length
    involves calculation and math functions

In this way, we can interpolate when the length cannot be represented
as a CSSLengthArray (i.e., when comparison functions min/max are
involved).

Bug: 991672
Change-Id: Ib83fc0a07d0eb1d03a2465ac9df5282f963b935b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777025
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694443}

TBR=alancutter@chromium.org,eae@chromium.org,xiaochengh@chromium.org,futhark@chromium.org

Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 991672
Change-Id: I4467c0b4c8202dbc38ac5152620666caa38648e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797822
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695498}

TBR=alancutter@chromium.org,eae@chromium.org,xiaochengh@chromium.org,futhark@chromium.org

Change-Id: I44ea1cba39aa2b8c16ed3ebd5a9b364ed9a3539b
Bug: 991672, 1002177

Reviewed-on: https://chromium-review.googlesource.com/1798249
WPT-Export-Revision: e96cd575d9fd53d864a3277e478620b501c4f46a

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

… expression"

This reverts commit b8229a7b3ecaed4f11210ef512d2c3099f79a33b.

Reason for revert: Fixing performance regression

Original change's description:
> Revert "Switch InterpolableLength implementation from length array to expression"
>
> This reverts commit dd1318d7b1537af982313d51433e00fc02421225.
>
> Reason for revert: caused performance regression crbug.com/1002177
>
> Original change's description:
> > Switch InterpolableLength implementation from length array to expression
> >
> > This patch changes the internal implementation of InterpolableLength
> > from CSSLengthArray to the following:
> > - A CSSNumericLiteralValue to keep it simple when it's a simple value
> > - A CSSMathExpressionNode to make it general when the underlying length
> >   involves calculation and math functions
> >
> > In this way, we can interpolate when the length cannot be represented
> > as a CSSLengthArray (i.e., when comparison functions min/max are
> > involved).
> >
> > Bug: 991672
> > Change-Id: Ib83fc0a07d0eb1d03a2465ac9df5282f963b935b
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777025
> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> > Reviewed-by: Alan Cutter <alancutter@chromium.org>
> > Reviewed-by: Emil A Eklund <eae@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#694443}
>
> TBR=alancutter@chromium.org,eae@chromium.org,xiaochengh@chromium.org,futhark@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 991672
> Change-Id: I4467c0b4c8202dbc38ac5152620666caa38648e0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797822
> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#695498}

TBR=alancutter@chromium.org,eae@chromium.org,xiaochengh@chromium.org,futhark@chromium.org

Change-Id: I44ea1cba39aa2b8c16ed3ebd5a9b364ed9a3539b
Bug: 991672, 1002177
@KyleJu
Copy link
Contributor

KyleJu commented Sep 26, 2019

Close this PR because the Chromium CL has been abandoned.

@KyleJu KyleJu closed this Sep 26, 2019
@KyleJu KyleJu deleted the chromium-export-cl-1798249 branch September 26, 2019 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants