Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macvim: fix compatibility with Xcode 11 #68534

Merged
merged 1 commit into from Sep 26, 2019
Merged

macvim: fix compatibility with Xcode 11 #68534

merged 1 commit into from Sep 26, 2019

Conversation

lilyball
Copy link
Member

Motivation for this change

This fixes several Xcode 11 incompatibilities with MacVim, including an issue where it wasn't inheriting the deployment target correctly to begin with.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I haven't actually tested but I'm pretty sure this package doesn't compile under sandbox, so don't bother trying.

Also see #68528. I tested by building with both patches applied simultaneously.

I haven't actually tested compiling this with Xcode 10.3 via Nix, but I did test the patches independently with Xcode 10.3 in a separate checkout of the MacVim project.

@lilyball
macvim: fix compatibility with Xcode 11
4563496 
This fixes several Xcode 11 incompatibilities with MacVim, including an
issue where it wasn't inheriting the deployment target correctly to
begin with.
@lilyball
Copy link
Member Author

Also see macvim-dev/macvim#936 which is the tracking issue on the MacVim side for Xcode 11 compatibility.

@ofborg ofborg bot added the 6.topic: vim label Sep 12, 2019
@ofborg ofborg bot requested a review from cstrahan September 12, 2019 03:34
@lheckemann lheckemann added this to the 19.09 milestone Sep 12, 2019
@Mic92 Mic92 mentioned this pull request Sep 22, 2019
Merged
@Mic92
Copy link
Member

Mic92 commented Sep 24, 2019

@GrahamcOfBorg build macvim

@lilyball
Copy link
Member Author

Xcode 11 is fully out and I would really like to get this merged

@lilyball
Copy link
Member Author

FWIW build failure by ofBorg is expected, the macvim package breaks purity and won't build under sandboxing.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/60

@Mic92 Mic92 merged commit 05a9276 into NixOS:master Sep 26, 2019
@Mic92
Copy link
Member

Mic92 commented Sep 26, 2019

[detached HEAD 5851328] macvim: fix compatibility with Xcode 11
Author: Lily Ballard lily@sb.org
Date: Wed Sep 11 20:13:36 2019 -0700
2 files changed, 30 insertions(+)
Press Enter to continue

@lilyball lilyball deleted the macvim-xcode-11-fix branch September 26, 2019 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
19.09
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lilyball @Mic92 @nixos-discourse @lheckemann