Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electrum.ltc: 3.1.3.1 -> 3.3.8.1 #68514

Merged
merged 1 commit into from Sep 12, 2019
Merged

electrum.ltc: 3.1.3.1 -> 3.3.8.1 #68514

merged 1 commit into from Sep 12, 2019

Conversation

ghost
Copy link

@ghost ghost commented Sep 11, 2019

Motivation for this change

Updates the electrum wallet and fixes a remote phishing vulnerability from February 2019. https://electrum-ltc.org/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @asymmetric

@asymmetric
Copy link
Contributor

asymmetric commented Sep 11, 2019

Oh wow, I thought nobody was using this and was even contemplating of proposing to remove it.

I'll have more time to review this next week, but generally I'm not using this package anymore. @ivegotasthma are you interested in (gradually) taking over maintainership, by adding yourself to the list of maintainers?

Thanks for the PR!

@ghost
Copy link
Author

ghost commented Sep 12, 2019

I found an old backup and wanted to see if there was anything there. I'm not using the package anymore as well. I think it would be better to remove it, since it needs to be kept up to date.

Is there a way to see usage statistics? Because if there are users, we should also make it verify the signature from the website.

@lheckemann lheckemann added this to the 19.09 milestone Sep 12, 2019
@mmahut
Copy link
Member

mmahut commented Sep 12, 2019

Build and tested this, going to backport to 19.09.

@mmahut mmahut merged commit c98af06 into NixOS:master Sep 12, 2019
@mmahut mmahut mentioned this pull request Sep 12, 2019
10 tasks
@asymmetric
Copy link
Contributor

Fails for me:

❯ nix-review pr 68514
$ git fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0 pull/68514/head:refs/nix-review/1
remote: Enumerating objects: 1499, done.
remote: Counting objects: 100% (1499/1499), done.
remote: Compressing objects: 100% (3/3), done.
remote: Total 3132 (delta 1496), reused 1496 (delta 1496), pack-reused 1633
Receiving objects: 100% (3132/3132), 2.43 MiB | 2.45 MiB/s, done.
Resolving deltas: 100% (2240/2240), completed with 639 local objects.
From https://github.com/NixOS/nixpkgs
   79ec84fb96f..046ea6d08fc  master     -> refs/nix-review/0
$ git worktree add /home/asymmetric/.cache/nix-review/pr-68514-1/nixpkgs 046ea6d08fce7bdc6360905adafae793310edfc2
Preparing worktree (detached HEAD 046ea6d08fc)
Checking out files: 100% (19831/19831), done.
HEAD is now at 046ea6d08fc ccacheWrapper: make usable with clang
$ git merge --no-commit 4c38d83e63c9632e8f5a73c8672146d9efee8991
Already up to date.
$ nix build --no-link --keep-going --max-jobs 4 --option build-use-sandbox true -f /home/asymmetric/.cache/nix-review/pr-68514-1/build.nix
[6 built, 12 copied (255.8 MiB), 35.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/68514
1 package were build:
electrum-ltc

$ nix-shell /home/asymmetric/.cache/nix-review/pr-68514-1/shell.nix
these paths will be fetched (0.05 MiB download, 0.28 MiB unpacked):
  /nix/store/w4bin8lakab76zmcvixql3x77w7329zs-bash-interactive-4.4-p23-dev
copying path '/nix/store/w4bin8lakab76zmcvixql3x77w7329zs-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...

[nix-shell:~/.cache/nix-review/pr-68514-1]$ results/electrum-ltc/bin/electrum-ltc
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Aborted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants