vimPlugins.deoplete-dictionary: init at 2019-04-16 #68464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
approved these changes
Sep 11, 2019
There was a problem hiding this comment.
This actually does an update as well, but thats alright.
nix-review passes on NixOS
diff LGTM
[93 built, 34 copied (824.4 MiB), 191.3 MiB DL]
https://github.com/NixOS/nixpkgs/pull/68464
47 package were build:
vimPlugins.ale vimPlugins.coc-git vimPlugins.coc-go vimPlugins.coc-pairs vimPlugins.coc-snippets vimPlugins.coc-tsserver vimPlugins.denite-git vimPlugins.denite-nvim vimPlugins.deol-nvim vimPlugins.deoplete-dictionary vimPlugins.deoplete-fish vimPlugins.deoplete-lsp vimPlugins.deoplete-nvim vimPlugins.falcon vimPlugins.fastfold vimPlugins.ghcid vimPlugins.iosvkem vimPlugins.julia-vim vimPlugins.lh-vim-lib vimPlugins.lightline-vim vimPlugins.neomake vimPlugins.neoterm vimPlugins.nerdtree vimPlugins.nvimdev-nvim vimPlugins.vim-airline vimPlugins.vim-autoformat vimPlugins.vim-elixir vimPlugins.vim-fireplace vimPlugins.vim-fugitive vimPlugins.vim-gitgutter vimPlugins.vim-go vimPlugins.vim-grepper vimPlugins.vim-jsx-pretty vimPlugins.vim-lsc vimPlugins.vim-plug vimPlugins.vim-polyglot vimPlugins.vim-rhubarb vimPlugins.vim-ruby vimPlugins.vim-sensible vimPlugins.vim-snippets vimPlugins.vim-table-mode vimPlugins.vim-test vimPlugins.vim-visual-multi vimPlugins.vimtex vimPlugins.yats-vim vimPlugins.youcompleteme vimPlugins.zig-vim
|
please split the addition of the plugin and the update into two commits (via git add -p for isntance) |
I was following the official instructions, which say to create a commit with an update before adding a new plugin.
The update and the addition are separate commits, with commit messages following the official instructions. |
|
you are right sorry :( |
|
@teto No problem :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add deoplete-dictionary vim plugin
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @