Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safari builds fail on web-share/share-sharePromise-internal-slot.https.html #18995

Closed
foolip opened this issue Sep 11, 2019 · 10 comments
Closed

Safari builds fail on web-share/share-sharePromise-internal-slot.https.html #18995

foolip opened this issue Sep 11, 2019 · 10 comments
Labels
Azure Pipelines infra priority:backlog
Projects
Reliable Safari results

Comments

@foolip
Copy link
Member

foolip commented Sep 11, 2019

STP on Azure Pipelines has been failing job 2 recently:

These are not the same failure mode as #18669, although I spotted some more of that too.

https://gist.github.com/foolip/d1cb47b31c7c50d859d4bb7f1ffa4e71 is the end of the logs for the first listed build, and the other two are similar.

It started happening right after #18967 was landed, so this is probably a persistent failure that won't go away, and thus urgent.
@foolip
Copy link
Member Author

foolip commented Sep 11, 2019

The test where everything falls apart is https://github.com/web-platform-tests/wpt/blob/master/web-share/share-sharePromise-internal-slot.https.html, which uses test_driver.bless(). A familiar pattern from #18635.

@Hexcles
Copy link
Member

Hexcles commented Sep 11, 2019

Interestingly, this test also trips a DCHECK on Chrome, which I'm not sure whether is a coincidence: https://crbug.com/1002514

@foolip
Copy link
Member Author

foolip commented Sep 11, 2019

This is probably also the cause for failure for Safari stable:
https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=30446

(Logs too big to view online, and don't know how to open huge textfiles in ChromeOS.)

foolip added a commit that referenced this issue Sep 11, 2019
@foolip
Exclude problematic web-share test from full Safari runs
7a6d0cb 
Workaround for #18995.
@foolip foolip mentioned this issue Sep 11, 2019
Merged
@foolip foolip changed the title Safari Technology Preview builds failing Safari builds fail on web-share/share-sharePromise-internal-slot.https.html Sep 11, 2019
foolip added a commit that referenced this issue Sep 11, 2019
@foolip
Exclude problematic web-share test from full Safari runs (#19003)
e2498db 
Workaround for #18995.
@foolip
Copy link
Member Author

foolip commented Sep 11, 2019

#19003 merged, these two builds will tell if that was enough to recover:
https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=30562
https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=30563

This was referenced Sep 11, 2019
Closed
Merged
@foolip
Copy link
Member Author

foolip commented Sep 11, 2019

Success! https://wpt.fyi/results/?sha=e2498db8b0&max-count=10

@foolip
Copy link
Member Author

foolip commented Sep 13, 2019

https://wpt.fyi/results/web-share/share-sharePromise-internal-slot.https.html?sha=857ac64cb1&label=pr_head (for #19004) showed that running just that test doesn't fail. So probably there's bad state that this test runs into, caused by some previous test.

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Sep 14, 2019
@foolip @moz-wptsync-bot
Bug 1580756 [wpt PR 19003] - Exclude problematic web-share test from …
07b3595 
…full Safari runs, a=testonly

Automatic update from web-platform-tests
Exclude problematic web-share test from full Safari runs (#19003)

Workaround for web-platform-tests/wpt#18995.
--

wpt-commits: e2498db8b0ffa8175fc10d32f3aa76783430af98
wpt-pr: 19003
xeonchen pushed a commit to xeonchen/gecko that referenced this issue Sep 14, 2019
@foolip @moz-wptsync-bot
Bug 1580756 [wpt PR 19003] - Exclude problematic web-share test from …
4bba5b5 
…full Safari runs, a=testonly

Automatic update from web-platform-tests
Exclude problematic web-share test from full Safari runs (#19003)

Workaround for web-platform-tests/wpt#18995.
--

wpt-commits: e2498db8b0ffa8175fc10d32f3aa76783430af98
wpt-pr: 19003
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 4, 2019
@marco-c
Bug 1580756 [wpt PR 19003] - Exclude problematic web-share test from …
9aa25dc 
…full Safari runs, a=testonly

Automatic update from web-platform-tests
Exclude problematic web-share test from full Safari runs (#19003)

Workaround for web-platform-tests/wpt#18995.
--

wpt-commits: e2498db8b0ffa8175fc10d32f3aa76783430af98
wpt-pr: 19003

UltraBlame original commit: 152da801027cad67d33763e59c5d53b45104f405
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 4, 2019
@marco-c
Bug 1580756 [wpt PR 19003] - Exclude problematic web-share test from …
95ae48b 
…full Safari runs, a=testonly

Automatic update from web-platform-tests
Exclude problematic web-share test from full Safari runs (#19003)

Workaround for web-platform-tests/wpt#18995.
--

wpt-commits: e2498db8b0ffa8175fc10d32f3aa76783430af98
wpt-pr: 19003

UltraBlame original commit: 152da801027cad67d33763e59c5d53b45104f405
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 4, 2019
@marco-c
Bug 1580756 [wpt PR 19003] - Exclude problematic web-share test from …
48c0f38 
…full Safari runs, a=testonly

Automatic update from web-platform-tests
Exclude problematic web-share test from full Safari runs (#19003)

Workaround for web-platform-tests/wpt#18995.
--

wpt-commits: e2498db8b0ffa8175fc10d32f3aa76783430af98
wpt-pr: 19003

UltraBlame original commit: 152da801027cad67d33763e59c5d53b45104f405
@foolip foolip added this to To do in Reliable Safari results via automation Dec 20, 2019
@foolip foolip mentioned this issue Dec 20, 2019
Merged
@foolip
Copy link
Member Author

foolip commented Dec 20, 2019

This is happening again in #20878, need to put back the --exclude for this test.

foolip added a commit that referenced this issue Dec 20, 2019
@foolip
Skip web-share/share-sharePromise-internal-slot.https.html in STP
01ed10a 
#18995 has resurfaced...
foolip added a commit that referenced this issue Dec 20, 2019
@foolip
Reland "Update Safari Technology Preview to 97" (#20888)
ed3830e 
This is https://github.com/web-platform-tests/wpt/pull/2088820863 with workaround for
#18995 and
#20887.
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jan 3, 2020
@foolip @moz-wptsync-bot
Bug 1605367 [wpt PR 20888] - Reland "Update Safari Technology Preview…
b4f256d 
… to 97", a=testonly

Automatic update from web-platform-tests
Reland "Update Safari Technology Preview to 97" (#20888)

This is https://github.com/web-platform-tests/wpt/pull/2088820863 with workaround for
web-platform-tests/wpt#18995 and
web-platform-tests/wpt#20887.
--

wpt-commits: ed3830ef10dd4cfa81dcbc7090b9a6b86a39ba64
wpt-pr: 20888
xeonchen pushed a commit to xeonchen/gecko that referenced this issue Jan 3, 2020
@foolip @moz-wptsync-bot
Bug 1605367 [wpt PR 20888] - Reland "Update Safari Technology Preview…
b391b0f 
… to 97", a=testonly

Automatic update from web-platform-tests
Reland "Update Safari Technology Preview to 97" (#20888)

This is https://github.com/web-platform-tests/wpt/pull/2088820863 with workaround for
web-platform-tests/wpt#18995 and
web-platform-tests/wpt#20887.
--

wpt-commits: ed3830ef10dd4cfa81dcbc7090b9a6b86a39ba64
wpt-pr: 20888
@gsnedders gsnedders mentioned this issue Jan 31, 2020
Closed
@gsnedders gsnedders removed their assignment Jan 31, 2020
@gsnedders gsnedders mentioned this issue Apr 4, 2020
Closed
@stephenmcgruer
Copy link
Contributor

Similar to the other issue I commented on today, it's not clear to me we should be tracking this. The bug here is that we can't handle Safari crashing during runs - the actual testing crashing is a WebKit bug to be filed, surely? The real issue here is #19620 (which tracks handling Safari crashing).

@foolip foolip mentioned this issue May 25, 2020
Closed
@foolip
Copy link
Member Author

foolip commented May 25, 2020

Yes, given a WebKit bug we could link to that instead and close this.

@gsnedders
Copy link
Member

Closing this as #27427 has meant we don't need to maintain a blocklist of tests; the rest of the issue here is a safaridriver one (probably rdar://74197601).

Reliable Safari results automation moved this from To do to Done Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Azure Pipelines infra priority:backlog
Projects
Reliable Safari results
  
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@stephenmcgruer @gsnedders @foolip @Hexcles