[LayoutNG] Fix abspos replaced size with margins #19011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 11, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1799422
branch
4 times, most recently
from
5a8e55d
to
0929b87
Compare
NG was computing inline_size of replaced elements with no intrinsic size (only aspect ratio) incorrectly. Element's margin was not considered. The fixes are: - update code to use margin when computing inline_size - update wpt exaustive replaced size test to include margins - remove many stale expectations for position-absolute-replaced-minmax.html With the updated test, Legacy still fails single test. I might have to update expectations. Bug: 1002748 Change-Id: I98b8595ce0e4dc0d19d1d8020e33fe17e125d41d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799422 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#696101}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1799422
branch
from
0929b87
to
2d589a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NG was computing inline_size of replaced elements
with no intrinsic size (only aspect ratio) incorrectly.
Element's margin was not considered.
The fixes are:
With the updated test, Legacy still fails single test. I might
have to update expectations.
Bug: 1002748
Change-Id: I98b8595ce0e4dc0d19d1d8020e33fe17e125d41d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799422
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696101}