Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cri-o: 1.15.1 -> 1.15.2 #68490

Merged
merged 1 commit into from Sep 16, 2019
Merged

cri-o: 1.15.1 -> 1.15.2 #68490

merged 1 commit into from Sep 16, 2019

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Sep 11, 2019 •
edited

Signed-off-by: Sascha Grunert sgrunert@suse.com

Motivation for this change

Updating CRI-O to the latest release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@saschagrunert
cri-o: 1.15.1 -> 1.15.2
3beb307 
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert
Copy link
Member Author

@GrahamcOfBorg build cri-o

jonringer
jonringer approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable seems to work
leaf package

@jonringer
Copy link
Contributor

since there's no darwin build, I guess my level of permission should be fine

@GrahamcOfBorg build cri-o

@saschagrunert
Copy link
Member Author

This update addresses CVE-2019-10214

@lheckemann lheckemann added this to the 19.09 milestone Sep 12, 2019
@disassembler disassembler merged commit 2981900 into NixOS:master Sep 16, 2019
disassembler pushed a commit that referenced this pull request Sep 16, 2019
@saschagrunert @disassembler
cri-o: 1.15.1 -> 1.15.2 (#68490)
2f35266 
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
(cherry picked from commit 2981900)
@saschagrunert saschagrunert deleted the cri-o branch September 16, 2019 05:41
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Sep 16, 2019
@saschagrunert @dtzWill
cri-o: 1.15.1 -> 1.15.2 (NixOS#68490)
a17486d 
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
(cherry picked from commit 2981900)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
19.09
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@saschagrunert @jonringer @lheckemann @disassembler