Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

factorio: experimental 0.17.52 -> 0.17.68 #68704

Closed
wants to merge 1 commit into from
Closed

factorio: experimental 0.17.52 -> 0.17.68 #68704

wants to merge 1 commit into from

Conversation

seppeljordan
Copy link
Contributor

@seppeljordan seppeljordan commented Sep 13, 2019 •
edited

Motivation for this change

factorio got updated upstream, also libpulseaudio is now required to start the application.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Baughn September 13, 2019 21:20
Baughn
Baughn reviewed Sep 14, 2019
View reviewed changes
pkgs/games/factorio/default.nix
@@ -1,5 +1,5 @@
{ stdenv, fetchurl, makeWrapper
, alsaLib, libX11, libXcursor, libXinerama, libXrandr, libXi, libGL
, alsaLib, libX11, libXcursor, libXinerama, libXrandr, libXi, libGL, libpulseaudio
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Pulseaudio is now required, then alsaLib probably will not be. Add a TODO by stable to test that theory once it catches up with 0.17.68.

@seppeljordan
Copy link
Contributor Author

I don't want to see this in my PR overview anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baughn Baughn Baughn left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seppeljordan @Baughn