Fix some Python3 compatibility issue. #19654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
added
infra
wptrunner
jgraham
requested changes
Oct 13, 2019
|
Generally this looks like a nice change; thanks. Just a small formatting issue to fix. |
This is done in order to improve compatibility with Python3
This is done in order to improve compatibility with Python3
jgraham
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on servo/servo#23607 for the servo project, i ended up having to fix some Python3 compatibility issues.
I am totally new to this project and never heard of it before trying to handle the issue aforementioned, so I apologize in advance if I have missed some basic steps before creating a pull request.
If everything is ok with you, I'll make subsequent PRs with more fixes as i end up encountering incompatibilities.