Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r19.09] libsoup: 2.66.2 -> 2.66.4, fixing CVE-2019-17266 #71029

Merged
merged 1 commit into from Oct 12, 2019
Merged

[r19.09] libsoup: 2.66.2 -> 2.66.4, fixing CVE-2019-17266 #71029

merged 1 commit into from Oct 12, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Oct 12, 2019 •
edited

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2019-17266

Doesn't build on darwin but that's not new.

And I don't have the capacity to rebuild all its reverse dependencies.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@vcunat vcunat self-assigned this Oct 12, 2019
@ofborg ofborg bot requested review from lovek323 and 7c6f434c October 12, 2019 12:28
vcunat
vcunat approved these changes Oct 12, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

News seem very nice https://gitlab.gnome.org/GNOME/libsoup/blob/2.66.4/NEWS

@vcunat vcunat changed the base branch from release-19.09 to staging-19.09 October 12, 2019 12:47
@vcunat vcunat changed the base branch from staging-19.09 to release-19.09 October 12, 2019 12:50
vcunat added a commit that referenced this pull request Oct 12, 2019
@vcunat
Merge #71029: libsoup: 2.66.2 -> 2.66.4
8e39110 
...into release-19.09, fixing CVE-2019-17266
@vcunat vcunat merged commit c3f0f74 into NixOS:release-19.09 Oct 12, 2019
@vcunat
Copy link
Member

vcunat commented Oct 12, 2019

19.03 has libsoup-2.64.2, so that shouldn't be affected, by reading the CVE.

@risicle
Copy link
Contributor Author

risicle commented Oct 12, 2019

Agreed ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@lovek323 lovek323 Awaiting requested review from lovek323

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees

@vcunat vcunat

Labels
1.severity: security 10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @vcunat @veprbl