Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pySMART_smartx: init at 0.3.10 #70927

Closed
wants to merge 1 commit into from
Closed

pythonPackages.pySMART_smartx: init at 0.3.10 #70927

wants to merge 1 commit into from
+21 −0

Conversation

marenz2569
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@marenz2569
pythonPackages.pySMART_smartx: init at 0.3.10

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
9546fa2
@marenz2569 marenz2569 requested a review from FRidh as a code owner October 10, 2019 18:44
@ofborg ofborg bot added 6.topic: python 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 10, 2019
@risicle
Copy link
Contributor

risicle commented Oct 10, 2019 •
edited
Loading

Two problems:

  1. This package seems to implicitly depend on smartctl being present in the user's PATH. To get it properly bound to its dependencies it'll probably require doing a bit of string replacement in the source looking for places it just does a Popen('smartctl ... and replacing them with absolute paths. There are a few of them.

  2. Tests don't actually run. Tests require pytest and will probably need a custom checkPhase cd'ing into pySMART/test and running pytest.

FRidh
FRidh requested changes Oct 15, 2019
View reviewed changes
pkgs/top-level/python-packages.nix
@@ -1040,6 +1040,8 @@ in {
inherit (pkgs) cmake qt5 ninja;
});

pySMART_smartx = callPackage ../development/python-modules/pySMART_smartx { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the attribute name needs to be a normalized name, so pysmart-smartx.

pkgs/development/python-modules/pySMART_smartx/default.nix
}:

buildPythonPackage rec {
pname = "pySMART.smartx";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use normalized name here as well

pkgs/development/python-modules/pySMART_smartx/default.nix
version = "0.3.10";

src = fetchPypi {
inherit pname version;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here pname = "pySMART.smartx";

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@ryantm ryantm added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 3, 2020
@Artturin Artturin closed this May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marenz2569 @risicle @FRidh @ryantm @Artturin