Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.arc-menu: 33.2 -> 33 #70923

Closed
wants to merge 1 commit into from
Closed

gnomeExtensions.arc-menu: 33.2 -> 33 #70923

wants to merge 1 commit into from
+3 −3

Conversation

dkabot
Copy link
Member

@dkabot dkabot commented Oct 10, 2019

Motivation for this change

Development version 33.2 does not work with current GNOME 3.34, giving the following error: TypeError: ExtensionSystem.connect is not a function
Using the stable version 33 (which is more recent, despite the number) resolves this, and makes the extension usable once again.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 10, 2019
@worldofpeace
Copy link
Contributor

Duplicate of #70533, I was also confused on the versioning.

@dkabot
Copy link
Member Author

dkabot commented Oct 10, 2019

Ah, sorry I missed that; I'll try to be more careful in the future.
Thanks for merging the other one!

@worldofpeace
Copy link
Contributor

Ah, sorry I missed that; I'll try to be more careful in the future.
Thanks for merging the other one!

Yeah, this does happen sometimes. But right, it did get merged one way or another 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dkabot @worldofpeace