Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mariadb: remove development components #70924

Merged
merged 4 commits into from Nov 15, 2019
Merged

mariadb: remove development components #70924

merged 4 commits into from Nov 15, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Oct 10, 2019 •
edited

Motivation for this change

Remove development components. Need to use only libmysqlclient package.
Update build configuration.

Please recheck build configuration.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from thoughtpolice October 10, 2019 18:46
@Izorkin Izorkin force-pushed the mariadb-remove-dev branch 2 times, most recently from 2e26f81 to 886077d Compare October 10, 2019 20:12
@ofborg ofborg bot requested a review from peterhoeg October 10, 2019 20:26
@Izorkin
Copy link
Contributor Author

Izorkin commented Oct 11, 2019

@GrahamcOfBorg build zoneminder

@Izorkin
Copy link
Contributor Author

Izorkin commented Oct 11, 2019

@GrahamcOfBorg build perlPackages.SysCPU

@Izorkin
Copy link
Contributor Author

Izorkin commented Oct 18, 2019

@GrahamcOfBorg build perlPackages.SysCPU

@Izorkin
Copy link
Contributor Author

Izorkin commented Oct 18, 2019

@volth thanks, added patch.

@Izorkin
Copy link
Contributor Author

Izorkin commented Oct 18, 2019

@GrahamcOfBorg build perlPackages.SysCPU

@Izorkin
Copy link
Contributor Author

Izorkin commented Oct 23, 2019

Use fetchpatch or doCheck ?

@Mic92
Copy link
Member

Mic92 commented Oct 23, 2019 •
edited

If tests work fine after applying patches, we can drop doCheck.
The staging patch should be reverted however.

@Izorkin
Copy link
Contributor Author

Izorkin commented Oct 23, 2019

@GrahamcOfBorg build perlPackages.SysCPU

@Izorkin
Copy link
Contributor Author

Izorkin commented Oct 24, 2019

@GrahamcOfBorg build perlPackages.SysCPU

@Izorkin
Copy link
Contributor Author

Izorkin commented Oct 24, 2019

@GrahamcOfBorg build mariadb zoneminder

@Izorkin
Copy link
Contributor Author

Izorkin commented Nov 6, 2019

Update Mariadb to version 10.3.19

@Izorkin Izorkin changed the title mariadb: remove development components mariadb: 10.3.18 -> 10.3.19 and remove development components Nov 7, 2019
@Izorkin Izorkin changed the title mariadb: 10.3.18 -> 10.3.19 and remove development components mariadb: remove development components Nov 7, 2019
@Izorkin Izorkin force-pushed the mariadb-remove-dev branch 2 times, most recently from f308b97 to ee42b6d Compare November 9, 2019 15:44
@Izorkin
Copy link
Contributor Author

Izorkin commented Nov 9, 2019

Update package to version 10.3.20

сс @thoughtpolice @matthewbauer @Mic92

@Izorkin Izorkin mentioned this pull request Nov 12, 2019
Merged
10 tasks
@Mic92 Mic92 merged commit 3102738 into NixOS:master Nov 15, 2019
@Izorkin Izorkin deleted the mariadb-remove-dev branch November 15, 2019 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Izorkin @Mic92